Preserve vault state on failed file operations

internal/api/api.go

@@ -4,6 +4,7 @@ package api
 import (
 	"encoding/json"
 	"errors"
+	"fmt"
 	"io"
 	"io/fs"
 	"log/slog"
@@ -359,6 +360,9 @@ func (s *Server) move(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 	if err := s.store.MoveShares(body.From, body.To); err != nil {
+		if rollback := s.vault.Move(body.To, body.From); rollback != nil {
+			err = errors.Join(err, fmt.Errorf("回滚笔记移动失败: %w", rollback))
+		}
 		internalError(w, r, err)
 		return
 	}

internal/api/api_test.go

@@ -31,6 +31,36 @@ type fixture struct {
 	admin *http.Client
 }
 
+func TestMoveRollsBackWhenShareUpdateFails(t *testing.T) {
+	dir := t.TempDir()
+	v, err := vault.Open(filepath.Join(dir, "vault"))
+	if err != nil {
+		t.Fatal(err)
+	}
+	if _, err := v.Write("from.md", []byte("原文"), vault.Precondition{}); err != nil {
+		t.Fatal(err)
+	}
+	st, err := store.Open(filepath.Join(dir, "test.db"))
+	if err != nil {
+		t.Fatal(err)
+	}
+	if err := st.Close(); err != nil {
+		t.Fatal(err)
+	}
+	s := New(v, nil, st, nil, nil)
+	res := httptest.NewRecorder()
+	s.move(res, httptest.NewRequest("POST", "/api/v1/move", strings.NewReader(`{"from":"from.md","to":"to.md"}`)))
+	if res.Code != 500 {
+		t.Fatalf("数据库失败应返回错误: %d", res.Code)
+	}
+	if content, _, err := v.Read("from.md"); err != nil || string(content) != "原文" {
+		t.Fatalf("原笔记未恢复: %q %v", content, err)
+	}
+	if _, err := os.Stat(filepath.Join(v.Root(), "to.md")); !os.IsNotExist(err) {
+		t.Fatalf("失败后目标仍存在: %v", err)
+	}
+}
+
 func newFixture(t *testing.T) *fixture {
 	t.Helper()
 	dir := t.TempDir()